openbsc[master]: libcommon: Fix log output for bts>0.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 12 09:26:32 UTC 2017


Patch Set 2:

(1 comment)

> Btw, Harald - any reason we're caching lchan log string, but
 > doesn't cache pchan log string?

We don't print pchan names anywhere nearly as frequently as lchan names. Have you seen the pchan name printing show up in any profiles?  We can certainly add it if needed.

https://gerrit.osmocom.org/#/c/3185/2/openbsc/tests/channel/channel_test.c
File openbsc/tests/channel/channel_test.c:

Line 73: 	bts = gsm_bts_alloc(network, 0);
actually, as you're modifying the test case, it would make a lot of sense to extend it to cover the actual situation with multiple BTSs and verifyng that the string contains the right BTS number.


-- 
To view, visit https://gerrit.osmocom.org/3185
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list