[PATCH] libosmo-abis[master]: configure.ac: Fix C(PP)FLAGS for BSD build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jul 6 08:34:32 UTC 2017


Review at  https://gerrit.osmocom.org/3137

configure.ac: Fix C(PP)FLAGS for BSD build

Issue first found in libosmocore. It seems the BSD build doesn't use
bash which means using += to append to a variable doesn't work
correctly.

Change-Id: Id509351104bc7466114d4b9be450814254110f44
---
M configure.ac
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/37/3137/1

diff --git a/configure.ac b/configure.ac
index 535d1c3..9b62f3e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,8 +26,8 @@
 
 AC_CONFIG_MACRO_DIR([m4])
 
-CFLAGS+=" -Wall"
-CPPFLAGS+=" -Wall"
+CFLAGS="$CFLAGS -Wall"
+CPPFLAGS="$CPPFLAGS -Wall"
 
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
@@ -58,8 +58,8 @@
 	[sanitize=$enableval], [sanitize="no"])
 if test x"$sanitize" = x"yes"
 then
-	CFLAGS+=" -fsanitize=address -fsanitize=undefined"
-	CPPFLAGS+=" -fsanitize=address -fsanitize=undefined"
+	CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined"
+	CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
 _cflags_save=$CFLAGS

-- 
To view, visit https://gerrit.osmocom.org/3137
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id509351104bc7466114d4b9be450814254110f44
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list