openbsc[master]: Fix BTS number in attribute requests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jul 2 07:07:32 UTC 2017


Patch Set 2:

You are sending the GET_ATTRIBUTE OML message to each bts type, and that includes an E1 based BTS.  Assuming what that BTS will do when receiving such a message with a "wrong" BTS number can be dangerous. Also, if the calls were specifically added for osmoBTS, why are they not subject to related conditionals? They could simply be issued only in case "OsmoBTS" is selected as bts->type.

-- 
To view, visit https://gerrit.osmocom.org/2868
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list