This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: l1sap: Don't enqueue PTCCH blocks for loopback ...................................................................... l1sap: Don't enqueue PTCCH blocks for loopback When we're in loopback testing mode for PDTCH, we must make sure to avoid adding PTCCH blocks to the queue. Only PDTCH blocks must be enqueued. For the transmit (downlink) side, we already had the PTCCH check in place. Change-Id: I7ef40d9bdf74a99375bc6568ed9483499664bf6f --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 85d1dd1..71690cd 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -967,7 +967,7 @@ lchan = get_lchan_by_chan_nr(trx, chan_nr); if (!lchan) LOGP(DL1P, LOGL_ERROR, "No lchan for chan_nr=%d\n", chan_nr); - if (lchan && lchan->loopback) { + if (lchan && lchan->loopback && !L1SAP_IS_PTCCH(fn)) { /* we are in loopback mode (for BER testing) * mode and need to enqeue the frame to be * returned in downlink */ -- To view, visit https://gerrit.osmocom.org/3081 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ef40d9bdf74a99375bc6568ed9483499664bf6f Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de>