osmo-bts[master]: OML: fill MO while handling attr. request

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 1 07:35:26 UTC 2017


Patch Set 1: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/#/c/3090/1/src/common/oml.c
File src/common/oml.c:

Line 1126: 		bts->mo.obj_inst.trx_nr = foh->obj_inst.trx_nr;
this most certainly is completely wrong.  The bts->mo is the instance of the managed object for the BTS. It's "MO Address" is configured once statically at BTS startup and never modified - *particularly* not by a get/read request.


-- 
To view, visit https://gerrit.osmocom.org/3090
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5a5ab8bd07daf2500b66dec428b89b7f8cd852
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list