osmo-bts[master]: OML: internalize failure reporting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jan 25 11:46:16 UTC 2017


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1570/5/src/common/oml.c
File src/common/oml.c:

Line 93: 	   oml_tx_failure_event_rep(), see handle_fail_sig() below */
this sort-of defeats a bit the idea of using the signals.  Why do we use signals?  So multiple interested entities can register for the signal.  But there is no guaranteed ordering in how the signal handlers are called.  You now register one that free()s part of the data, so if it is called before another signal handler, that other handler will no longer get passed the data.  I don't have a bright idea at this point.  Maybe use a static buffer for printing the string? aftre all, our "signals" are synchronous, i.e. no second oml_fail_rep() can ever be called before all registered signal handlers hve executed. Any other idas?


-- 
To view, visit https://gerrit.osmocom.org/1570
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I738555c547926e97b325ab53763c0076c42309bc
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list