libosmocore[master]: CTRL: add write-only helpers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 12 22:32:28 UTC 2017


Patch Set 2: Code-Review+1

(2 comments)

I see that it's copying from _RO, but couldn't resist to comment...

https://gerrit.osmocom.org/#/c/1574/2/include/osmocom/ctrl/control_cmd.h
File include/osmocom/ctrl/control_cmd.h:

Line 192: static int get_##cmdname(struct ctrl_cmd *cmd, void *data)	\
backslashes don't line up


Line 194: 	cmd->reply = "Write Only attribute";				\
could be nice to add the #cmdstr in the reply message?


-- 
To view, visit https://gerrit.osmocom.org/1574
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b7990db590c1f8e56326e392e6c1d2eafebd9a
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list