This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) nice, it seems DEBUGP so far didn't take advantage of early exiting to prevent performance loss when debug level is not enabled? Excellent catch! two minor details... https://gerrit.osmocom.org/#/c/1580/1/include/osmocom/core/logging.h File include/osmocom/core/logging.h: Line 39: LOGPSRC(ss, level, NULL, 0, fmt, ## args) why move this around? IMHO its place above LOGPC makes more sense than below. https://gerrit.osmocom.org/#/c/1580/1/src/logging.c File src/logging.c: Line 434 We should probably keep this implementation around for backwards compat with binary code built with old DEBUGP macros ... until when, the next major release? forever? -- To view, visit https://gerrit.osmocom.org/1580 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6c92bd4824c44fc22cc733ce7a88da86e58ed93 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes