This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) This is *not* about a segfault. It's about an assertion and abort() (SIGABRT is not SIGSEGV). Nice, by this patch I understand where the problem is, but... I find that the API added by this patch is bad, and I'd rather solve the issue like this: https://gerrit.osmocom.org/1586 Nicest would be if the test case itself could either remove the VTY elements to get a clean start for each individual test run, or maybe split TbfTest into several separate binaries to achieve the same. But the least effort is #1586, which has no footprint in production API and no adverse effects. Do you agree? https://gerrit.osmocom.org/#/c/1579/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: Line 849: gprs_ns_vty_init(bssgp_nsi); problem: this omits the step where the vty_nsi pointer is set to point at bssgp_nsi. The bool init_vty arg thus makes no sense except for a (clumsy) test case setup. -- To view, visit https://gerrit.osmocom.org/1579 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I975cee6b2b21e1e83649f2ce23203568f225bd7a Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes