This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1582
to look at the new patch set (#2).
vty: remove ignored logging parameters
Related: OS#71
Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
---
M include/osmocom/vty/logging.h
M src/vty/logging_vty.c
M tests/vty/vty_test.c
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/1582/2
diff --git a/include/osmocom/vty/logging.h b/include/osmocom/vty/logging.h
index 9e4b98f..a23a1ad 100644
--- a/include/osmocom/vty/logging.h
+++ b/include/osmocom/vty/logging.h
@@ -4,6 +4,6 @@
#define FILTER_STR "Filter log messages\n"
struct log_info;
-void logging_vty_add_cmds(const struct log_info *cat);
+void logging_vty_add_cmds(const struct log_info *unused_info);
struct vty;
struct log_target *osmo_log_vty2tgt(struct vty *vty);
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 6004c47..1c51ec7 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -737,7 +737,7 @@
return 1;
}
-void logging_vty_add_cmds(const struct log_info *cat)
+void logging_vty_add_cmds(const struct log_info *unused_info)
{
install_element_ve(&enable_logging_cmd);
install_element_ve(&disable_logging_cmd);
@@ -750,8 +750,8 @@
install_element_ve(&logging_set_category_mask_old_cmd);
/* Logging level strings are generated dynamically. */
- logging_level_cmd.string = log_vty_command_string(cat);
- logging_level_cmd.doc = log_vty_command_description(cat);
+ logging_level_cmd.string = log_vty_command_string(NULL);
+ logging_level_cmd.doc = log_vty_command_description(NULL);
install_element_ve(&logging_level_cmd);
install_element_ve(&show_logging_vty_cmd);
install_element_ve(&show_alarms_cmd);
diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c
index 865c93e..51a6529 100644
--- a/tests/vty/vty_test.c
+++ b/tests/vty/vty_test.c
@@ -318,7 +318,7 @@
vty_init(&vty_info);
/* Setup VTY commands */
- logging_vty_add_cmds(&log_info);
+ logging_vty_add_cmds(NULL);
osmo_stats_vty_add_cmds();
test_cmd_string_from_valstr();
--
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder