[PATCH] osmo-bts[master]: lc15, sysmobts l1_if: fix memleak in handle_mph_time_ind()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 12 11:13:42 UTC 2017


Hello jfdionne, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1566

to look at the new patch set (#2).

lc15,sysmobts l1_if: fix memleak in handle_mph_time_ind()

Change-Id: I3061060235a488b114b636b3af9a2253a94de1e8
---
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/1566/2

diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index 99533d7..c70bd9e 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -647,6 +647,7 @@
 
 	/* ignore every time indication, except for c0 */
 	if (trx != bts->c0) {
+		msgb_free(msg);
 		return 0;
 	}
 
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index ad9aa64..82db8d7 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -642,6 +642,7 @@
 
 	/* ignore every time indication, except for c0 */
 	if (trx != bts->c0) {
+		msgb_free(msg);
 		return 0;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/1566
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3061060235a488b114b636b3af9a2253a94de1e8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jean-Francois Dionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jfdionne <jf.dionne at nutaq.com>



More information about the gerrit-log mailing list