[MERGED] libosmo-abis[master]: handle_ts1_read(): log sign_link() error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jan 10 23:29:28 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: handle_ts1_read(): log sign_link() error
......................................................................


handle_ts1_read(): log sign_link() error

Change-Id: I95779ee8590ab16b7af4ad2c79ede68da3a12e5a
---
M src/input/ipaccess.c
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 675f07a..9e64471 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -228,7 +228,7 @@
 	struct e1inp_sign_link *link;
 	struct ipaccess_head *hh;
 	struct msgb *msg = NULL;
-	int ret;
+	int ret, rc;
 
 	ret = ipa_msg_recv_buffered(bfd->fd, &msg, &e1i_ts->pending_msg);
 	if (ret < 0) {
@@ -273,13 +273,14 @@
 		ret = -EINVAL;
 		goto err_msg;
 	}
-	if (e1i_ts->line->ops->sign_link(msg) < 0) {
+	rc = e1i_ts->line->ops->sign_link(msg);
+	if (rc < 0) {
 		/* Don't close the signalling link if the upper layers report
 		 * an error, that's too strict. BTW, the signalling layer is
 		 * resposible for releasing the message.
 		 */
 		LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"
-			"sign_link returned error\n");
+		     " sign_link returned error: %s.\n", strerror(-rc));
 	}
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/1549
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95779ee8590ab16b7af4ad2c79ede68da3a12e5a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list