This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change and it was merged. Change subject: RSL: drop obsolete NULL check ...................................................................... RSL: drop obsolete NULL check rsl_rx_paging_cmd() checks if the pointer *trx is NULL, this check does not make much sense since *trx has already been dereferenced without checking earlier in the code. Furthermore *trx is also a mandatory parameter which must not be NULL. Fixes: coverity scan CID#159534 Change-Id: I17dfb42ff404b2a1e18354fb7a7278089b407a79 --- M src/common/rsl.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/rsl.c b/src/common/rsl.c index be1861c..41dd2ce 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -402,7 +402,7 @@ identity_lv, chan_needed); if (rc < 0) { /* FIXME: notfiy the BSC on other errors? */ - if (rc == -ENOSPC && trx) + if (rc == -ENOSPC) oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MIN_PAG_TAB_FULL, "BTS paging table is full\n"); -- To view, visit https://gerrit.osmocom.org/1544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17dfb42ff404b2a1e18354fb7a7278089b407a79 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de>