[PATCH] openbsc[master]: vty: fix subscr ref count leak in 'subscriber name' cmd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Feb 23 19:28:23 UTC 2017


Review at  https://gerrit.osmocom.org/1881

vty: fix subscr ref count leak in 'subscriber name' cmd

Change-Id: I3d19518c94a7f302bf108f2ad945983cdc8db0b1
---
M openbsc/src/libmsc/vty_interface_layer3.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/81/1881/1

diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c
index ddec2e3..cd5dfb7 100644
--- a/openbsc/src/libmsc/vty_interface_layer3.c
+++ b/openbsc/src/libmsc/vty_interface_layer3.c
@@ -586,6 +586,7 @@
 		vty_out(vty,
 			"%% NAME is too long, max. %zu characters are allowed%s",
 			sizeof(subscr->name)-1, VTY_NEWLINE);
+		subscr_put(subscr);
 		return CMD_WARNING;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/1881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d19518c94a7f302bf108f2ad945983cdc8db0b1
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list