This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged.
Change subject: debug.h/c: remove unused cruft / cosmetic tweaks
......................................................................
debug.h/c: remove unused cruft / cosmetic tweaks
Change-Id: I9601d478763569933bcc46bf4eaaff70a9843be9
---
M openbsc/include/openbsc/debug.h
M openbsc/src/libcommon/debug.c
2 files changed, 2 insertions(+), 13 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/openbsc/include/openbsc/debug.h b/openbsc/include/openbsc/debug.h
index ca00fe9..6300020 100644
--- a/openbsc/include/openbsc/debug.h
+++ b/openbsc/include/openbsc/debug.h
@@ -1,5 +1,4 @@
-#ifndef _DEBUG_H
-#define _DEBUG_H
+#pragma once
#include <stdio.h>
#include <osmocom/core/linuxlist.h>
@@ -41,17 +40,8 @@
Debug_LastEntry,
};
-/* we don't need a header dependency for this... */
-struct gprs_nsvc;
-struct bssgp_bvc_ctx;
struct gsm_subscriber;
void log_set_imsi_filter(struct log_target *target, struct gsm_subscriber *subscr);
-void log_set_nsvc_filter(struct log_target *target,
- struct gprs_nsvc *nsvc);
-void log_set_bvc_filter(struct log_target *target,
- struct bssgp_bvc_ctx *bctx);
extern const struct log_info log_info;
-
-#endif /* _DEBUG_H */
diff --git a/openbsc/src/libcommon/debug.c b/openbsc/src/libcommon/debug.c
index 51fbb93..3f3232c 100644
--- a/openbsc/src/libcommon/debug.c
+++ b/openbsc/src/libcommon/debug.c
@@ -177,8 +177,7 @@
},
};
-static int filter_fn(const struct log_context *ctx,
- struct log_target *tar)
+static int filter_fn(const struct log_context *ctx, struct log_target *tar)
{
const struct gsm_subscriber *subscr = ctx->ctx[LOGGING_CTX_VLR_SUBSCR];
const struct gprs_nsvc *nsvc = ctx->ctx[LOGGING_CTX_GB_NSVC];
--
To view, visit https://gerrit.osmocom.org/1846
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9601d478763569933bcc46bf4eaaff70a9843be9
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>