This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/1861/1/src/bts.cpp File src/bts.cpp: Line 46: #define MAX_FN 2715648 I think this is GSM_MAX_FN from <osmocom/gsm/gsm_utils.h> so maybe better to use it? Line 534: * reference. This PCU implementation has to fit both secenarious, so scenarios Line 547: fn_rounded = m_cur_fn - m_cur_rfn; as we are using unsigned integers in a modulus arrithmetic: what happens if m_cur_rfn is larger than m_cur_fn? does the function still work in this case? *If* this case is "imposible" then we should try to fail gracefully and print a related error message (and test for it in the test case). -- To view, visit https://gerrit.osmocom.org/1861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f00c11e5739d49f370ce6c357149e81d9aa759 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes