This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/1841/2//COMMIT_MSG
Commit Message:
Line 7: Expand CTRL interface
ETOOGENERAL: 'CTRL: add enable/disable packet service cmds' ?
https://gerrit.osmocom.org/#/c/1841/2/src/ctrl.c
File src/ctrl.c:
Line 41: if (db_subscr_get(gs->dbc, cmd->value, NULL) < 0) {
ah that's why. Rather check the number of modified rows in db_subscr_ps()?
https://gerrit.osmocom.org/#/c/1841/2/src/db_hlr.c
File src/db_hlr.c:
Line 57: if (subscr) {
why would I pass a NULL subscr to db_subscr_get()?
https://gerrit.osmocom.org/#/c/1841/2/src/luop.c
File src/luop.c:
Line 271: void lu_op_tx_del_subscr_data(struct lu_operation *luop)
this is not related to the ctrl interface, right?
--
To view, visit https://gerrit.osmocom.org/1841
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23163ce8667292443ed61cb15c928357dba4b4be
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes