This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 10: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/1198/10/src/input/unixsocket.c File src/input/unixsocket.c: Line 251: msgb_put_u32(msg, 0x23004200); this needs to be done properly. Right now we are basically puting some magic value here instead of a LAPD frame, and it' s "pure magic" that this magic value is not interpreted as LAPD on the other side. Rather, we should add an additional header (pushing one or two bytes in front of each message) to allow the receiver to distinguish LAPD payload from control frames. The header should include a version number so we can change the protocol as needed later. -- To view, visit https://gerrit.osmocom.org/1198 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5723b09a5c68a0505829dc732def981e60a907a Gerrit-PatchSet: 10 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-HasComments: Yes