This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 4: Code-Review-1
(3 comments)
I think given we have configs in the wild that include everything.. where it might or might not be intended.. we should have a new name.. "all" maybe?
git grep everything -- openbsc/doc/ | wc -l
7
https://gerrit.osmocom.org/#/c/1582/4/include/osmocom/vty/logging.h
File include/osmocom/vty/logging.h:
Line 7: void logging_vty_add_cmds(const struct log_info *unused_info);
then remove it... as long as we don't write (void) the compiler should not complain..
https://gerrit.osmocom.org/#/c/1582/4/src/logging.c
File src/logging.c:
Line 142: "Log everything (use with extreme care)",
What about existing configs that write "everything"? Maybe introduce "all" and have everything as an alias for "XYZ???"
Line 356: static inline bool log_to_target(struct log_target *tar, int subsys, int level)
But it doesn't look. it is a rather long predicate function.. should_log_to_target?
--
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes