[PATCH] osmo-bts[master]: Cosmetic fixes

[Max]

Review at  https://gerrit.osmocom.org/1776

Cosmetic fixes

* print actual value causing error and the check range
* fix log error message typo
* use preprocessor #if 0 to avoid compilation warning for disabled code

Change-Id: Icb536f951386b9abe34c0dacbb203f3db1e41bb3
---
M src/common/scheduler.c
M src/osmo-bts-trx/gsm0503_coding.c
2 files changed, 12 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/1776/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 724fb5a..27b7630 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -305,11 +305,11 @@
 			goto wrong_type;
 		}
 		if (prim_fn > 100) {
-			LOGP(DL1C, LOGL_NOTICE, "Prim for trx=%u ts=%u at fn=%u "
-			     "is out of range, or channel %s with type %s is "
-			     "already disabled. If this happens in conjunction "
-			     "with PCU, increase 'rts-advance' by 5. "
-			     "(current fn=%u)\n", l1t->trx->nr, tn,
+			LOGP(DL1C, LOGL_NOTICE, "Prim %u for trx=%u ts=%u at "
+			     "fn=%u is out of range (100), or channel %s with "
+			     "type %s is already disabled. If this happens in "
+			     "conjunction with PCU, increase 'rts-advance' by 5."
+			     " (current fn=%u)\n", prim_fn, l1t->trx->nr, tn,
 			     l1sap->u.data.fn,
 			     get_lchan_by_chan_nr(l1t->trx, chan_nr)->name,
 			     get_value_string(trx_chan_type_names, chan), fn);
@@ -1609,10 +1609,12 @@
 no_data:
 	/* in case of C0, we need a dummy burst to maintain RF power */
 	if (bits == NULL && l1t->trx == l1t->trx->bts->c0) {
-if (0)		if (chan != TRXC_IDLE) // hack
-		LOGP(DL1C, LOGL_DEBUG, "No burst data for %s fn=%u ts=%u "
-			"burst=%d on C0, so filling with dummy burst\n",
-			trx_chan_desc[chan].name, fn, tn, bid);
+#if 0
+		if (chan != TRXC_IDLE) // hack
+			LOGP(DL1C, LOGL_DEBUG, "No burst data for %s fn=%u ts=%u "
+			     "burst=%d on C0, so filling with dummy burst\n",
+			     trx_chan_desc[chan].name, fn, tn, bid);
+#endif
 		bits = (ubit_t *) dummy_burst;
 	}
 
diff --git a/src/osmo-bts-trx/gsm0503_coding.c b/src/osmo-bts-trx/gsm0503_coding.c
index 4c4f7f1..4278974 100644
--- a/src/osmo-bts-trx/gsm0503_coding.c
+++ b/src/osmo-bts-trx/gsm0503_coding.c
@@ -1845,7 +1845,7 @@
 
 	rv = osmo_crc8gen_check_bits(&gsm0503_tch_fr_crc3, d + 73, 22, p);
 	if (rv) {
-		LOGP(DL1C, LOGL_NOTICE, "tch_fr_decode(): error checking CRC8 for an HR frame\n");
+		LOGP(DL1C, LOGL_NOTICE, "tch_hr_decode(): error checking CRC8 for an HR frame (%d/%d bits)\n", *n_errors, *n_bits_total);
 		return -1;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/1776
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb536f951386b9abe34c0dacbb203f3db1e41bb3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>