osmo-bts[master]: octphy: Fix VTY commands

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 8 14:08:03 UTC 2017


Patch Set 3:

(3 comments)

please also address the two commit message comments above (summary, quotes)

https://gerrit.osmocom.org/#/c/1711/3/src/osmo-bts-octphy/octphy_vty.c
File src/osmo-bts-octphy/octphy_vty.c:

Line 172: 		vty_out(vty, "Error fetching stats!%s", VTY_NEWLINE);
": invalid msgb size (%d bytes, expected %d bytes)"

if (sizeof > msgb_l2len) would be enough?


Line 176: 	tOCTVC1_HW_MSG_RF_PORT_STATS_RSP *psr =
heh didn't you say recently that variables should be declared at the top of the function? It's Osmocom convention anyway.


Line 227: 		vty_out(vty, "Error fetching stats!%s", VTY_NEWLINE);
(same as above)


-- 
To view, visit https://gerrit.osmocom.org/1711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae5aa91fe2ebba7c2874eed88b15ed66e8c9cd61
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list