This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1643 to look at the new patch set (#2). cs RAB: lower guaranteedBitrate This is mimicking the IEs found in a trace from a production 3G environment. We have no reason to add this other than knowing that other operators seem to do this. This came up while trying to fix voice RAB for the nano3G, but this patch had no effect on that. Now that it's here, we might as well keep it. Change-Id: Ia7eecca43d62a6a020466e9b8dc8b566ca988f9f --- M src/ranap_msg_factory.c M src/tests/test-ranap.ok 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/43/1643/2 diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index cd2ddfc..36a39c2 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -569,7 +569,7 @@ ASN_SEQUENCE_ADD(&rab->maxBitrate.list, new_long(12200)); rab->guaranteedBitRate = CALLOC(1, sizeof(*rab->guaranteedBitRate)); - ASN_SEQUENCE_ADD(rab->guaranteedBitRate, new_long(12200)); + ASN_SEQUENCE_ADD(rab->guaranteedBitRate, new_long(6700)); rab->deliveryOrder = RANAP_DeliveryOrder_delivery_order_requested; rab->maxSDU_Size = 244; diff --git a/src/tests/test-ranap.ok b/src/tests/test-ranap.ok index dc959eb..fdff38f 100644 --- a/src/tests/test-ranap.ok +++ b/src/tests/test-ranap.ok @@ -88,7 +88,7 @@ <id>53</id> <firstCriticality><reject/></firstCriticality> <firstValue> - 78 02 CD 80 10 2F A7 20 2F A8 00 00 F4 4C 08 0A + 78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 08 0A 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 3D 02 00 02 0D C0 35 00 01 0A 0B 0C 0D 40 09 26 00 00 @@ -100,14 +100,14 @@ <id>54</id> <criticality><ignore/></criticality> <value> - 00 00 01 00 35 00 3B 78 02 CD 80 10 2F A7 20 2F - A8 00 00 F4 4C 08 0A 02 80 00 51 40 00 27 20 28 + 00 00 01 00 35 00 3B 78 02 CD 80 10 2F A7 20 1A + 2C 00 00 F4 4C 08 0A 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 3D 02 00 02 0D C0 35 00 01 0A 0B 0C 0D 40 09 26 00 00 40 01 00 </value> </RANAP_IE> -00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 2f a8 00 00 f4 4c 08 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 +00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 08 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 ==> RAB ASSIGNMENT COMMAND (DATA) <RANAP_ProtocolIE-FieldPair> -- To view, visit https://gerrit.osmocom.org/1643 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7eecca43d62a6a020466e9b8dc8b566ca988f9f Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder