This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1716
to look at the new patch set (#2).
cosmetic: sql: indicate VARCHAR size of key columns as 32
Notably this has no functional effect (according to
https://sqlite.org/faq.html#q9 ), but it can't hurt to indicate intent.
Change-Id: I2b0f9369318085c1482c6d2d8db56699466bfbf3
---
M sql/hlr.sql
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/16/1716/2
diff --git a/sql/hlr.sql b/sql/hlr.sql
index ab9d173..e05587b 100644
--- a/sql/hlr.sql
+++ b/sql/hlr.sql
@@ -54,15 +54,15 @@
CREATE TABLE auc_2g (
subscriber_id INTEGER PRIMARY KEY, -- subscriber.id
algo_id_2g INTEGER NOT NULL,
- ki VARCHAR NOT NULL
+ ki VARCHAR(32) NOT NULL
);
CREATE TABLE auc_3g (
subscriber_id INTEGER PRIMARY KEY, -- subscriber.id
algo_id_3g INTEGER NOT NULL,
k VARCHAR(32) NOT NULL,
- op VARCHAR,
- opc VARCHAR,
+ op VARCHAR(32),
+ opc VARCHAR(32),
sqn INTEGER
);
--
To view, visit https://gerrit.osmocom.org/1716
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b0f9369318085c1482c6d2d8db56699466bfbf3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder