This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: (5 comments) I'm trying to factor this out from the VLR branch to start submitting while still focusing mostly on the VLR branch HEAD; in effect, this is still immature. Thanks for reviewing to pinpoint those immaturities. https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libbsc/bsc_subscriber.c File openbsc/src/libbsc/bsc_subscriber.c: Line 113: else in case of TMSI == GSM_RESERVED_TMSI, could print "unknown" instead, here. https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libbsc/bsc_vty.c File openbsc/src/libbsc/bsc_vty.c: Line 1024: vty_out(vty, " Use count: %d%s", bsub->use_count, VTY_NEWLINE); > ->name has some overlap.. shall we have tmsi != GSM_RESERVED_TMSI.. in the in principle yes, but what else can we print if neither IMSI nor TMSI are available? I think my decision was to then print GSM_RESERVED_TMSI... could also print "(unknown)" instead. https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libbsc/paging.c File openbsc/src/libbsc/paging.c: Line 80 > no replacement for this? I'm trying to push this away, see also https://gerrit.osmocom.org/#/c/1685/ Your opinion on #1685 would be much appreciated... I dimly remember that you said the IMSI filter didn't work so well anyway. True? https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libcommon-cs/common_cs.c File openbsc/src/libcommon-cs/common_cs.c: Line 73: net->bsc_subscribers = talloc_zero(net, struct llist_head); > only done to have a talloc context? for talloc yes, also thinking of a case in the OsmoCSCN where there are no bsc_subscribers ... so then the llist would be NULL altogether to indicate absence of libbsc. (hmm, did I add the null checks for that?) https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libmsc/gsm_subscriber.c File openbsc/src/libmsc/gsm_subscriber.c: Line 97: bsub = bsc_sub_have_by_imsi(conn->network->bsc_subscribers, subscr->imsi); (no bsc_subscribers NULL check here, or anywhere, really) -- To view, visit https://gerrit.osmocom.org/1682 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes