[MERGED] osmo-sgsn[master]: Remove obsolete ./configure option

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Sun Dec 31 11:02:19 UTC 2017


Max has submitted this change and it was merged.

Change subject: Remove obsolete ./configure option
......................................................................


Remove obsolete ./configure option

The '--enable-vty-tests' is just alias to '--enable-external-tests'
anyway.

Change-Id: I6230cfcf10247b601e16e7b872305499815520a9
---
M README.vty-tests
M configure.ac
M contrib/jenkins.sh
3 files changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/README.vty-tests b/README.vty-tests
index ba1b87c..0669ea8 100644
--- a/README.vty-tests
+++ b/README.vty-tests
@@ -4,7 +4,7 @@
 
 and pass the following configure options here:
 
-  ./configure --enable-vty-tests --enable-external-tests
+  ./configure --enable-external-tests
 
 The VTY tests are then included in the standard check target:
 
diff --git a/configure.ac b/configure.ac
index e886fa5..b89c046 100644
--- a/configure.ac
+++ b/configure.ac
@@ -150,11 +150,6 @@
 
 CHECK_TM_INCLUDES_TM_GMTOFF
 
-AC_ARG_ENABLE([vty_tests],
-		AC_HELP_STRING([--enable-vty-tests],
-				[Include the VTY/CTRL tests in make check (deprecated)
-				[default=no]]),
-		[enable_ext_tests="$enableval"],[enable_ext_tests="no"])
 AC_ARG_ENABLE([external_tests],
 		AC_HELP_STRING([--enable-external-tests],
 				[Include the VTY/CTRL tests in make check [default=no]]),
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index d2db0c9..a32be1e 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -46,12 +46,12 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize $SMPP $MGCP $IU --enable-vty-tests --enable-external-tests
+./configure --enable-sanitize $SMPP $MGCP $IU --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="--enable-osmo-bsc --enable-nat $SMPP $MGCP $IU --enable-vty-tests --enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="--enable-osmo-bsc --enable-nat $SMPP $MGCP $IU --enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh
 

-- 
To view, visit https://gerrit.osmocom.org/5606
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6230cfcf10247b601e16e7b872305499815520a9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list