This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: VLR: remove unused parameter ...................................................................... VLR: remove unused parameter The expire_lu is never used but is printed for every subscriber. Let's remove it to avoid confusion. Change-Id: I6f7ad1670836384d1e6a58f47a13464fdbbf8509 --- M include/osmocom/msc/vlr.h M src/libmsc/vty_interface_layer3.c 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h index 1b365a9..d68b7be 100644 --- a/include/osmocom/msc/vlr.h +++ b/include/osmocom/msc/vlr.h @@ -136,7 +136,6 @@ bool la_allowed; int use_count; - time_t expire_lu; /* FIXME: overlap with periodic_lu_timer/age_indicator */ struct osmo_fsm_inst *lu_fsm; struct osmo_fsm_inst *auth_fsm; diff --git a/src/libmsc/vty_interface_layer3.c b/src/libmsc/vty_interface_layer3.c index 02a3600..65ba178 100644 --- a/src/libmsc/vty_interface_layer3.c +++ b/src/libmsc/vty_interface_layer3.c @@ -64,7 +64,6 @@ { int reqs; struct llist_head *entry; - char expire_time[200]; if (strlen(vsub->name)) vty_out(vty, " Name: '%s'%s", vsub->name, VTY_NEWLINE); @@ -109,12 +108,6 @@ osmo_hexdump(t->vec.kc, sizeof(t->vec.kc)), VTY_NEWLINE); } - - /* print the expiration time of a subscriber */ - strftime(expire_time, sizeof(expire_time), - "%a, %d %b %Y %T %z", localtime(&vsub->expire_lu)); - expire_time[sizeof(expire_time) - 1] = '\0'; - vty_out(vty, " Expiration Time: %s%s", expire_time, VTY_NEWLINE); reqs = 0; llist_for_each(entry, &vsub->cs.requests) -- To view, visit https://gerrit.osmocom.org/5620 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f7ad1670836384d1e6a58f47a13464fdbbf8509 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder