[PATCH] osmo-ttcn3-hacks[master]: MGCP_Test: be more liberal in some of the error codes we expect

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 28 13:21:18 UTC 2017


Review at  https://gerrit.osmocom.org/5612

MGCP_Test: be more liberal in some of the error codes we expect

Sometimes it's not entirely clear which error code should be returned,
so let's accept multiple options, depending on the situation

Change-Id: I6d6eaec4d025b9da170f59c759884afe2e768521
---
M mgw/MGCP_Test.ttcn
1 file changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/5612/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 7c3889a..516944a 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -212,7 +212,7 @@
 	/* Send DLCX and expect OK response */
 	function f_dlcx_ok(MgcpEndpoint ep, template MgcpCallId call_id := omit,
 			   template MgcpConnectionId conn_id := omit) runs on dummy_CT {
-		f_dlcx(ep, "200", "OK", call_id, conn_id);
+		f_dlcx(ep, ("200","250"), "OK", call_id, conn_id);
 	}
 
 	/* Send DLCX and accept any response */
@@ -296,7 +296,7 @@
 		var template MgcpCommand cmd;
 		var MgcpResponse resp;
 		var MgcpEndpoint ep := "2 at mgw";
-		var template MgcpResponse rtmpl := tr_MgcpResp_Err("400");
+		var template MgcpResponse rtmpl := tr_MgcpResp_Err(("400","516"));
 
 		f_init(ep);
 
@@ -316,7 +316,7 @@
 		var MgcpResponse resp;
 		var MgcpEndpoint ep := "2 at mgw";
 		var MgcpCallId call_id := '1229'H;
-		var template MgcpResponse rtmpl := tr_MgcpResp_Err("400");
+		var template MgcpResponse rtmpl := tr_MgcpResp_Err(("400","517"));
 
 		f_init(ep);
 
@@ -420,8 +420,7 @@
 		var MgcpEndpoint ep := "4 at mgw";
 		var template MgcpResponse rtmpl := {
 			line := {
-				/* TODO: accept/enforce better error? */
-				code := "400",
+				code := ("400", "515"),
 				string := ?
 			},
 			params:= { },

-- 
To view, visit https://gerrit.osmocom.org/5612
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d6eaec4d025b9da170f59c759884afe2e768521
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list