[PATCH] osmo-iuh[master]: comments: hnbgw_rua.c: remove obsolete fixmes for asn1 free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Dec 24 23:46:58 UTC 2017


Review at  https://gerrit.osmocom.org/5580

comments: hnbgw_rua.c: remove obsolete fixmes for asn1 free

The comments are all right above the line that does the proper asn1 free step.

Change-Id: I60e3be8c56ecc75c22e76f9e9dce8c72753e153b
---
M src/hnbgw_rua.c
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/5580/1

diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c
index 58bb23b..b2b8792 100644
--- a/src/hnbgw_rua.c
+++ b/src/hnbgw_rua.c
@@ -361,7 +361,7 @@
 	rc = rua_to_scu(hnb, ies.cN_DomainIndicator, OSMO_SCU_PRIM_N_CONNECT,
 			context_id, 0, ies.ranaP_Message.buf,
 			ies.ranaP_Message.size);
-	/* FIXME: what to do with the asn1c-allocated memory */
+
 	rua_free_connecties(&ies);
 
 	return rc;
@@ -396,7 +396,6 @@
 			OSMO_SCU_PRIM_N_DISCONNECT,
 			context_id, scu_cause, ranap_data, ranap_len);
 
-	/* FIXME: what to do with the asn1c-allocated memory */
 	rua_free_disconnecties(&ies);
 
 	return rc;
@@ -423,7 +422,6 @@
 			context_id, 0, ies.ranaP_Message.buf,
 			ies.ranaP_Message.size);
 
-	/* FIXME: what to do with the asn1c-allocated memory */
 	rua_free_directtransferies(&ies);
 
 	return rc;

-- 
To view, visit https://gerrit.osmocom.org/5580
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60e3be8c56ecc75c22e76f9e9dce8c72753e153b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list