osmo-iuh[master]: vty: tweak / improve HNB and cnlink introspection

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 21 11:47:52 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/5532/1/src/hnbgw_vty.c
File src/hnbgw_vty.c:

Line 120: 	
whitespace


Line 151:     vty_out(vty, "%s:%u", inet_ntoa(addr.sin_addr), addr.sin_port);
please don't introduce new IPv4-only-isms without good reason.  Using inet_ntop would have not been any more difficult but more future proof.

Also, we do have osmo_sock_get_name() in libosmocore/socket.c, which performs both getosckname and getpeername and provides you with a nice string representation.  This is what's used in other places already, so I'd appreciate if we could use it here, too.

If you really need only the local address, please refactor osmo_sock_get_name() in libosmocore and use it from here.


-- 
To view, visit https://gerrit.osmocom.org/5532
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c937306a011715e163a40bc8ef8ec7e8d4e5d08
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list