[MERGED] osmo-iuh[master]: fix 3 compiler warnings in ranap_common.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 20 15:55:14 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: fix 3 compiler warnings in ranap_common.c
......................................................................


fix 3 compiler warnings in ranap_common.c

ranap_common.c:282 col 45: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘RANAP_CauseNon_Standard_t {aka const long int}’ [-Wformat=]
ranap_common.c:527 col 15: warning: implicit declaration of function ‘asn1str_to_u16’; did you mean ‘asn_strtol’? [-Wimplicit-function-declaration]
ranap_common.c:546 col 11: warning: unused variable ‘addr’ [-Wunused-variable]

Change-Id: I0b399e78fa7b202a36e5e4be86f338c0ceb9823e
---
M src/ranap_common.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ranap_common.c b/src/ranap_common.c
index 13c913f..46203e0 100644
--- a/src/ranap_common.c
+++ b/src/ranap_common.c
@@ -24,6 +24,7 @@
 #include <osmocom/gsm/gsm48.h>
 
 #include <osmocom/ranap/ranap_common.h>
+#include <asn1c/asn1helpers.h>
 
 extern int asn1_xer_print;
 int _ranap_DRANAP = 0;
@@ -278,7 +279,7 @@
 					cause->choice.misc));
 		break;
 	case RANAP_Cause_PR_non_Standard:
-		snprintf(buf, sizeof(buf), "non-standard(%u)",
+		snprintf(buf, sizeof(buf), "non-standard(%ld)",
 			cause->choice.non_Standard);
 		break;
 	default:
@@ -542,7 +543,6 @@
 
 int ranap_ip_from_transp_layer_addr(const BIT_STRING_t *in, uint32_t *ip)
 {
-	uint32_t addr;
 	uint8_t x213[] = {0x35, 0x00, 0x01};
 
 	/* Only support IPv4 for now - plain and with x213 encapsulation */

-- 
To view, visit https://gerrit.osmocom.org/5489
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b399e78fa7b202a36e5e4be86f338c0ceb9823e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list