[PATCH] osmo-bsc[master]: gsm_data.h: Document all fields of gsm_subscriber_connection

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5507

to look at the new patch set (#2).

gsm_data.h: Document all fields of gsm_subscriber_connection

Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/5507/2

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 1cedef0..2e97055 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -75,20 +75,26 @@
 	/* libbsc subscriber information (if available) */
 	struct bsc_subscr *bsub;
 
-	/* bsc structures */
-	struct osmo_bsc_sccp_con *sccp_con; /* BSC */
+	/* SCCP connection associatd with this subscriber_connection */
+	struct osmo_bsc_sccp_con *sccp_con;
 
 	/* back pointers */
 	struct gsm_network *network;
 
-	struct gsm_lchan *lchan; /* BSC */
-	struct gsm_lchan *ho_lchan; /* BSC */
-	struct gsm_bts *bts; /* BSC */
+	/* the primary / currently active lchan to the BTS/subscriber */
+	struct gsm_lchan *lchan;
+	/* the future/allocated but not yet used lchan during HANDOVER */
+	struct gsm_lchan *ho_lchan;
+	/* a short-hand pointer to the BTS currently serving the subscriber,
+	 * points to gsm_subscriber_connection.lchan->ts->trx->bts */
+	struct gsm_bts *bts;
 
-	/* for assignment handling */
-	struct osmo_timer_list T10; /* BSC */
-	struct gsm_lchan *secondary_lchan; /* BSC */
+	/* timer for assignment handling */
+	struct osmo_timer_list T10;
+	/* the future allocated but not yet used lchan during ASSIGNMENT */
+	struct gsm_lchan *secondary_lchan;
 
+	/* buffer/cache for classmark of the ME of the subscriber */
 	struct gsm_classmark classmark;
 
 	uint16_t lac;

-- 
To view, visit https://gerrit.osmocom.org/5507
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder