[PATCH] osmo-bsc[master]: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Dec 19 17:13:42 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5505

to look at the new patch set (#2).

osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6
---
M include/osmocom/bsc/osmo_bsc.h
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/5505/2

diff --git a/include/osmocom/bsc/osmo_bsc.h b/include/osmocom/bsc/osmo_bsc.h
index 13072c2..131007b 100644
--- a/include/osmocom/bsc/osmo_bsc.h
+++ b/include/osmocom/bsc/osmo_bsc.h
@@ -19,8 +19,10 @@
 struct bsc_msc_connection;
 
 struct osmo_bsc_sccp_con {
+	/* list_head anchoring us to gsm_network.subscr_conns */
 	struct llist_head entry;
 
+	/* flag to prevent multiple simultaneous ciphering commands */
 	int ciphering_handled;
 
 	/* for audio handling */
@@ -48,9 +50,12 @@
 	/* SCCP connection realted */
 	struct bsc_msc_data *msc;
 
+	/* back-pointer to subscriber connection */
 	struct gsm_subscriber_connection *conn;
+	/* state related to welcome USSD */
 	uint8_t new_subscriber;
 
+	/* state related to osmo_bsc_filter.c */
 	struct bsc_filter_state filter_state;
 
 	/* Sigtran connection ID */

-- 
To view, visit https://gerrit.osmocom.org/5505
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list