This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 13:
(2 comments)
https://gerrit.osmocom.org/#/c/4980/13/src/libmsc/iucs.c
File src/libmsc/iucs.c:
Line 224: LOGP(DIUCS, LOGL_DEBUG,
(here's another candidate for a common LOGPFOO() context macro ... probably also applies for the rest of this file; so I'd pass this patch without one and change over to a proper macro separately)
https://gerrit.osmocom.org/#/c/4980/13/src/libmsc/iucs_ranap.c
File src/libmsc/iucs_ranap.c:
Line 53: printf("transportLayerAddress present!\n");
-1: drop the printf, but I know you're working on that FIXME at the moment, so waiting for the next patch set.
--
To view, visit https://gerrit.osmocom.org/4980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea9630358b3963261fa1993cf1f3b563ff23538
Gerrit-PatchSet: 13
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes