libosmo-sccp[master]: ss7: Re-bind xUA server socket after setting new IP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 19 11:58:27 UTC 2017


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c
File src/osmo_ss7.c:

Line 426: /*! \brief bind all xUA servers belonging to an SS7 Instance
don't add new \brief, we use AUTOBRIEF (see Doxyfile). Just make sure the first sentence ends in a '.'


Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto,
to keep the public API backwards compatible, you should rather introduce osmo_ss7_xua_server_create2(), keeping osmo_ss7_xua_server_create() behavior identical but deprecating it (call osmo_ss7_xua_server_create2() and then open the link on it). The advantage is that we can migrate dependent code at any time without breaking anything until we do. (but... we don't need any more patches in osmo-msc and osmo-bsc, right? because the vty changes are in here?)


-- 
To view, visit https://gerrit.osmocom.org/4893
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list