This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1:
I took a look now and currently the LOGGING_STR is used for log_vty_command_description(), which composes the doc string for logging_level_cmd, which is installed in all of VIEW, ENABLE and CONFIG nodes as well as the log target nodes by logging_vty.c:logging_vty_add_cmds():
logging_level_cmd.string = log_vty_command_string();
logging_level_cmd.doc = log_vty_command_description();
install_element_ve(&logging_level_cmd);
[...]
install_element(CFG_LOG_NODE, &logging_level_cmd);
[...]
install_element(CFG_LOG_NODE, &logging_level_cmd);
To have differing doc strings for these nodes would take a bit more effort, looks like we'd need to separate these.
Most logging commands are also used on both install_element_ve() and the CFG_LOG_NODE.
I guess it makes more sense to use a generally matching LOGGING_STR than going for the effort of separating this. If you agree I could go through that code, do the separation and some more talloc_asprintf_append() simplifications; but other tasks should probably come first, right?
--
To view, visit https://gerrit.osmocom.org/5253
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1ee59c7d1073502259b7d60008206ac3d8e87a3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No