osmo-msc[master]: debug log: enrich Cipher Mode Cmd log in a_iface_tx_cipher_m...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 18 02:33:45 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/5374/2/src/libmsc/a_iface.c
File src/libmsc/a_iface.c:

Line 176: 	LOGP(DMSC, LOGL_DEBUG, "(subscr %s, conn_id %d) Cipher Mode Command to BSC,"
> please introduce a helper macro like we have in many other places so we can
I actually considered exactly that, but thought that it would only be used this once. Taking another look, I see that the logging in this file could use an overhaul and such a function would indeed be useful to cover numerous other places that so far lack proper log context.


-- 
To view, visit https://gerrit.osmocom.org/5374
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib406d6e6784342341e716206997e382c702ac9d2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list