[MERGED] osmo-hlr[master]: luop.c: Transform FIXME from warning to pragma message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Dec 16 13:20:04 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: luop.c: Transform FIXME from warning to pragma message
......................................................................


luop.c: Transform FIXME from warning to pragma message

This way the issue is still visible but we can enable Werror to avoid
introducing new warnings.

Change-Id: I6c9b195bf0e3f853e202cdbdb72d35d83cd2a2ab
---
M src/luop.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/luop.c b/src/luop.c
index 2966380..4ef4ea3 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -251,8 +251,7 @@
 	gsup.msisdn_enc = msisdn_enc;
 	gsup.msisdn_enc_len = l;
 
-	/* FIXME: deal with encoding the following data */
-	gsup.hlr_enc;
+	#pragma message "FIXME: deal with encoding the following data: gsup.hlr_enc"
 
 	if (luop->is_ps) {
 		/* FIXME: PDP infos - use more fine-grained access control

-- 
To view, visit https://gerrit.osmocom.org/5425
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c9b195bf0e3f853e202cdbdb72d35d83cd2a2ab
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list