[PATCH] libosmocore[master]: fix osmo_identifier_valid(): only allow printable characters

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5427

to look at the new patch set (#2).

fix osmo_identifier_valid(): only allow printable characters

In particular disallow ASCII 0..31 (control characters) and 127 (DEL).

Change-Id: I04469988495af03c881fe81d7786ca7f71636299
---
M src/utils.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/27/5427/2

diff --git a/src/utils.c b/src/utils.c
index bc5329d..8f56227 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -444,6 +444,8 @@
 		/* check for 7-bit ASCII */
 		if (str[i] & 0x80)
 			return false;
+		if (!isprint((int)str[i]))
+			return false;
 		/* check for some explicit reserved control characters */
 		if (strchr(illegal_chars, str[i]))
 			return false;

-- 
To view, visit https://gerrit.osmocom.org/5427
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04469988495af03c881fe81d7786ca7f71636299
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder