osmo-bts[master]: osmo-bts-trx: add error concealment unit for GSM-FR

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Dec 15 08:55:23 UTC 2017


Patch Set 4:

Hello Vadim,

I have moved at least the bit offsets to libosmocore now. See #5385 for that.

I also wanted to move the code for the ecu, but then I realized that in its
current form it would not be so helpful. The probelm I see is that since it
runs on the BTS it uses the RTP bit ordering, but you probably need the GSM
bit ordering. I am not sure how easy it is to fix this, probably we just
have to add a GSM version of the bit offset table und have it parameterizable
which of the two to use.

Probably it makes sense if you just take the patch from osmo-bsc and add a
parameter for the table. If that works for you and the original unit-test still
passes I could re-test on osmo-bts-trx.

best regards.
Philipp

-- 
To view, visit https://gerrit.osmocom.org/5214
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list