osmo-gsm-tester[master]: osmo_hlr.py: fix auth algo mapping, properly indicate COMP128v1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Dec 14 15:43:57 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/5358/2/src/osmo_gsm_tester/util.py
File src/osmo_gsm_tester/util.py:

Line 38: ENUM_OSMO_AUTH_ALGO = (OSMO_AUTH_ALGO_NONE, 'comp128v1', 'comp128v2', 'comp128v3', 'xor', 'milenage')
I see no changes in the NITB, why?

If this is only used in OsmoHlr, I'd prefer having a generic list of algos (non osmocom specific, sort order not important) in here or directly in schema, then have the function to transform to algo id in OsmoHlr.


-- 
To view, visit https://gerrit.osmocom.org/5358
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a6ce92468a6ae46136ad4f62381da261fd196c8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list