[MERGED] osmo-ggsn[master]: ggsn.c: Improve logging info on link-local ipv6 addr not found

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: ggsn.c: Improve logging info on link-local ipv6 addr not found
......................................................................


ggsn.c: Improve logging info on link-local ipv6 addr not found

Change-Id: I18fb952514712ff30d18c7626f84309055d3efa1
---
M ggsn/ggsn.c
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index fa3e20c..ef2357b 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -194,6 +194,7 @@
 	struct in46_prefix ipv6_tun_linklocal_ip;
 	struct in46_prefix *blacklist;
 	int blacklist_size;
+	int rc;
 
 	if (apn->started)
 		return 0;
@@ -247,9 +248,10 @@
 		}
 
 		if (apn->cfg.apn_type_mask & (APN_TYPE_IPv6|APN_TYPE_IPv4v6)) {
-			if (tun_ip_local_get(apn->tun.tun, &ipv6_tun_linklocal_ip, 1, IP_TYPE_IPv6_LINK) < 1) {
-				LOGPAPN(LOGL_ERROR, apn, "Cannot obtain IPv6 link-local address of "
-					"interface: %s\n", strerror(errno));
+			rc = tun_ip_local_get(apn->tun.tun, &ipv6_tun_linklocal_ip, 1, IP_TYPE_IPv6_LINK);
+			if (rc < 1) {
+				LOGPAPN(LOGL_ERROR, apn, "Cannot obtain IPv6 link-local address of interface: %s\n",
+					rc ? strerror(errno) : "tun interface has no link-local IP assigned");
 				apn_stop(apn, false);
 				return -1;
 			}

-- 
To view, visit https://gerrit.osmocom.org/5346
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18fb952514712ff30d18c7626f84309055d3efa1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder