[MERGED] osmo-bsc[master]: Add per-BTS rate_ctr for total + failed number of RSL CHAN_ACT

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Add per-BTS rate_ctr for total + failed number of RSL CHAN_ACT
......................................................................


Add per-BTS rate_ctr for total + failed number of RSL CHAN_ACT

Change-Id: I471b598af194dee78ebaa3414b6290c72d9bbcff
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/abis_rsl.c
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 776fcfe..44fba86 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -201,6 +201,8 @@
 	BTS_CTR_PAGING_ALREADY,
 	BTS_CTR_PAGING_RESPONDED,
 	BTS_CTR_PAGING_EXPIRED,
+	BTS_CTR_CHAN_ACT_TOTAL,
+	BTS_CTR_CHAN_ACT_NACK,
 };
 
 static const struct rate_ctr_desc bts_ctr_description[] = {
@@ -220,6 +222,8 @@
 	[BTS_CTR_PAGING_ALREADY] = 		{"paging:already", "Paging attempts ignored as subsciber was already being paged."},
 	[BTS_CTR_PAGING_RESPONDED] = 		{"paging:responded", "Paging attempts with successful paging response."},
 	[BTS_CTR_PAGING_EXPIRED] = 		{"paging:expired", "Paging Request expired because of timeout T3113."},
+	[BTS_CTR_CHAN_ACT_TOTAL] =		{"chan_act:total", "Total number of Channel Activations."},
+	[BTS_CTR_CHAN_ACT_NACK] =		{"chan_act:nack", "Number of Channel Activations that the BTS NACKed"},
 };
 
 static const struct rate_ctr_group_desc bts_ctrg_desc = {
diff --git a/src/libbsc/abis_rsl.c b/src/libbsc/abis_rsl.c
index fbaaf09..0f5361e 100644
--- a/src/libbsc/abis_rsl.c
+++ b/src/libbsc/abis_rsl.c
@@ -691,6 +691,8 @@
 
 	msg->dst = lchan->ts->trx->rsl_link;
 
+	rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_ACT_TOTAL]);
+
 	return abis_rsl_sendmsg(msg);
 }
 
@@ -1314,6 +1316,8 @@
 
 	osmo_timer_del(&msg->lchan->act_timer);
 
+	rate_ctr_inc(&msg->lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_ACT_NACK]);
+
 	if (msg->lchan->state == LCHAN_S_BROKEN) {
 		LOGP(DRSL, LOGL_ERROR,
 			"%s CHANNEL ACTIVATE NACK for broken channel.\n",

-- 
To view, visit https://gerrit.osmocom.org/5351
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I471b598af194dee78ebaa3414b6290c72d9bbcff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder