[PATCH] osmo-bsc[master]: Reduce T3113 default from 60s to 10s

[Harald Welte]

Reduce T3113 default from 60s to 10s

Our T3113 timer default of 60s was set early in the development of
OpenBSC, where we didn't really know what values to use and used
excessively large/safe values. Paging the same MS for 60 seconds (even
if there's no paging response) will however create a lot of PCH load for
no good reason.

It seems there's no clear guidance as to what the value should be. Other
implementations use something in the order of 10 seconds (OpenBTS,
yateBTS), which seems more realistic. THe Siemens BS-11 has a default of
5 seconds.

Let's be conservative and go to 10s as a default, which is already 6
times less potential PCH usage than our default so far...

Closes: OS#2756
Change-Id: If9c8441939c6fdcf6e2b9ede8cc576eb86296209
---
M include/osmocom/bsc/gsm_data.h
M src/libcommon/gsm_data_shared.c
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/5343/2

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 3fdc826..776fcfe 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -276,7 +276,7 @@
 #define GSM_T3107_DEFAULT 5	/* s */
 #define GSM_T3109_DEFAULT 19	/* s, must be 2s + radio_link_timeout*0.48 */
 #define GSM_T3111_DEFAULT 2	/* s */
-#define GSM_T3113_DEFAULT 60
+#define GSM_T3113_DEFAULT 10	/* s */
 #define GSM_T3115_DEFAULT 10
 #define GSM_T3117_DEFAULT 10
 #define GSM_T3119_DEFAULT 10
diff --git a/src/libcommon/gsm_data_shared.c b/src/libcommon/gsm_data_shared.c
index 30ef1ca..c14047d 100644
--- a/src/libcommon/gsm_data_shared.c
+++ b/src/libcommon/gsm_data_shared.c
@@ -347,7 +347,7 @@
 		sizeof(bts->gprs.cell.rlc_cfg));
 
 	/* init statistics */
-	bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, 0);
+	bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr);
 	if (!bts->bts_ctrs) {
 		talloc_free(bts);
 		return NULL;

-- 
To view, visit https://gerrit.osmocom.org/5343
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9c8441939c6fdcf6e2b9ede8cc576eb86296209
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder