[PATCH] osmo-pcu[master]: DL window: constify resend_needed() function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Dec 14 11:33:32 UTC 2017


Review at  https://gerrit.osmocom.org/5334

DL window: constify resend_needed() function

It doesn't change any state so mark it as const.

Change-Id: I5d672bfd654198aebb187772de464c52b3209435
---
M src/rlc.cpp
M src/rlc.h
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/34/5334/1

diff --git a/src/rlc.cpp b/src/rlc.cpp
index acd4169..c52417d 100644
--- a/src/rlc.cpp
+++ b/src/rlc.cpp
@@ -58,7 +58,7 @@
 	m_v_b.reset();
 }
 
-int gprs_rlc_dl_window::resend_needed()
+int gprs_rlc_dl_window::resend_needed() const
 {
 	for (uint16_t bsn = v_a(); bsn != v_s(); bsn = mod_sns(bsn + 1)) {
 		if (m_v_b.is_nacked(bsn) || m_v_b.is_resend(bsn))
diff --git a/src/rlc.h b/src/rlc.h
index ee86c2a..14d2082 100644
--- a/src/rlc.h
+++ b/src/rlc.h
@@ -303,7 +303,7 @@
 	const uint16_t distance() const;
 
 	/* Methods to manage reception */
-	int resend_needed();
+	int resend_needed() const;
 	int mark_for_resend();
 	void update(BTS *bts, char *show_rbb, uint16_t ssn,
 			uint16_t *lost, uint16_t *received);

-- 
To view, visit https://gerrit.osmocom.org/5334
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d672bfd654198aebb187772de464c52b3209435
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list