[PATCH] osmo-bsc[master]: cosmetic: osmo_bsc_mgcp: improve comments

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Dec 13 13:37:43 UTC 2017


Review at  https://gerrit.osmocom.org/5319

cosmetic: osmo_bsc_mgcp: improve comments

Make the comments for struct mgcp_ctx more expressive

Change-Id: Ie80b4915055e3f944ff1870c38e3609197ab72b2
---
M include/osmocom/bsc/osmo_bsc_mgcp.h
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/5319/1

diff --git a/include/osmocom/bsc/osmo_bsc_mgcp.h b/include/osmocom/bsc/osmo_bsc_mgcp.h
index f7106b6..7452513 100644
--- a/include/osmocom/bsc/osmo_bsc_mgcp.h
+++ b/include/osmocom/bsc/osmo_bsc_mgcp.h
@@ -23,12 +23,17 @@
 #include <osmocom/mgcp_client/mgcp_common.h>
 #include <osmocom/mgcp_client/mgcp_client.h>
 
-/* MGCP state handler context (fsm etc..) */
+/* MGCP state handler context. This context information stores all information
+ * to handle the direction of the RTP streams via MGCP. There is one instance
+ * of this context struct per subscriber connection.
+ * (see also struct osmo_bsc_sccp_con) */
 struct mgcp_ctx {
 	/* FSM instance, which handles the connection switching procedure */
 	struct osmo_fsm_inst *fsm;
 
-	/* RTP endpoint number */
+	/* RTP endpoint number. This number number identifies the endpoint
+	 * on the MGW on which the BTS and NET connection is created. This
+	 * endpoint number is assigned and released automatically. */
 	uint16_t rtp_endpoint;
 
 	/* RTP connection identifiers */

-- 
To view, visit https://gerrit.osmocom.org/5319
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie80b4915055e3f944ff1870c38e3609197ab72b2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list