python/osmo-python-tests[master]: Move scripts to appropriate directory

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 12 14:28:08 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/5278/1//COMMIT_MSG
Commit Message:

Line 7: Move scripts to appropriate directory
IIUC the problem is not mixing library code with scripts, it's much more mixing py2 and py3 files?

Last time I checked the library code was installed in /usr/local/lib/python* while the runnable scripts ended up in /usr/local/bin, so having one dir looks fine to me. Could you indicate the specific error and its solution in detail?


https://gerrit.osmocom.org/#/c/5278/1/setup.py
File setup.py:

Line 31: 		   "scripts/osmo_verify_transcript_ctrl.py"]
> Do they end up installed in the same place as before? otherwise jobs using 
'setup.py install' should make them end up in the same dir, but I am not sure whether all of our build jobs indeed use a locally installed version instead of checking out their own local osmo-python-tests and trying to use that. So I'm still afraid this may cause fallout.


-- 
To view, visit https://gerrit.osmocom.org/5278
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30cdf0f85b2a60a235960911c9827f4129da40db
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list