[PATCH] osmo-pcu[master]: TBF: remove unused variable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Dec 8 13:11:53 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5219

to look at the new patch set (#3).

TBF: remove unused variable

The num_T_exp is write-only so it can be safely dropped.

Change-Id: I94d83ca8c9b2f0732b53fdf42b17ba93cd7f1c15
---
M src/tbf.cpp
M src/tbf.h
2 files changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/19/5219/3

diff --git a/src/tbf.cpp b/src/tbf.cpp
index a35b4aa..6e59824 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -171,7 +171,6 @@
 	poll_ts(0),
 	n3105(0),
 	T(0),
-	num_T_exp(0),
 	fT(0),
 	num_fT_exp(0),
 	state(GPRS_RLCMAC_NULL),
@@ -552,7 +551,6 @@
 	LOGPC(DRLCMAC, (T != tbf->T) ? LOGL_ERROR : LOGL_DEBUG, "\n");
 
 	tbf->T = T;
-	tbf->num_T_exp = 0;
 
 	/* Tunning timers can be safely re-scheduled. */
 	tbf->timer.data = tbf;
@@ -1105,8 +1103,6 @@
 {
 	LOGP(DRLCMAC, LOGL_DEBUG, "%s timer %u expired.\n",
 		tbf_name(this), T);
-
-	num_T_exp++;
 
 	if (T) {
 		LOGP(DRLCMAC, LOGL_ERROR, "%s timer expired in unknown mode: %u\n",
diff --git a/src/tbf.h b/src/tbf.h
index 6bd4703..4906245 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -268,7 +268,6 @@
 
 	struct osmo_timer_list	timer;
 	unsigned int T; /* Txxxx number */
-	unsigned int num_T_exp; /* number of consecutive T expirations */
 	
 	struct osmo_gsm_timer_list	gsm_timer;
 	unsigned int fT; /* fTxxxx number */

-- 
To view, visit https://gerrit.osmocom.org/5219
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94d83ca8c9b2f0732b53fdf42b17ba93cd7f1c15
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list