[MERGED] osmo-bsc[master]: use _NUM_CHREQ_T to define the size of ctype_by_chreq

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 6 13:25:36 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: use _NUM_CHREQ_T to define the size of ctype_by_chreq
......................................................................


use _NUM_CHREQ_T to define the size of ctype_by_chreq

Make it future compatible for changes. Otherwise it will break
when additional enums are adding to chreq in libosmocore.
Depends on libosmocore Id67ba8de89dd6288e449197438e9e1c5d7f5a134

Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 91aee43..1ca3bc9 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -395,7 +395,7 @@
 		enum rrlp_mode mode;
 	} rrlp;
 
-	enum gsm_chan_t ctype_by_chreq[18];
+	enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T];
 
 	/* Use a TCH for handling requests of type paging any */
 	int pag_any_tch;

-- 
To view, visit https://gerrit.osmocom.org/4947
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list