osmo-gsm-tester[master]: OsmoBtsOctphy: Integrate with OsmoPcu and OsmoSgsn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 4 17:27:01 UTC 2017


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/5008/2/src/osmo_gsm_tester/bts_octphy.py
File src/osmo_gsm_tester/bts_octphy.py:

Line 177:         config.overlay(values, sgsn_conf)
heh, why not

  if self.sgsn:
    config.overlay...


-- 
To view, visit https://gerrit.osmocom.org/5008
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54780971d711d47b23976dd044a4a53134dd4299
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list