[MERGED] osmo-bsc[master]: cosmetic: add missing log prefix

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Dec 3 13:08:23 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: add missing log prefix
......................................................................


cosmetic: add missing log prefix

the log messages have prefixes that mark important phases (CRCX/BTS,
etc...). Some lines lack the prefix.

Add missing prefixes.

Change-Id: Iea5ea9e54f4b5c998b1d5fe18a98a94abd7b728b
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_mgcp.c b/src/osmo-bsc/osmo_bsc_mgcp.c
index 6753212..0c5d86b 100644
--- a/src/osmo-bsc/osmo_bsc_mgcp.c
+++ b/src/osmo-bsc/osmo_bsc_mgcp.c
@@ -193,7 +193,7 @@
 	mgcp_ctx->rtp_endpoint = rtp_endpoint;
 
 	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG,
-		 "creating connection for the BTS side on " "MGW endpoint:%x...\n", rtp_endpoint);
+		 "CRCX/BTS: creating connection for the BTS side on " "MGW endpoint:%x...\n", rtp_endpoint);
 
 	/* Generate MGCP message string */
 	mgcp_msg = (struct mgcp_msg) {
@@ -351,11 +351,11 @@
 	rtp_endpoint = mgcp_ctx->rtp_endpoint;
 
 	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG,
-		 "completing connection for the BTS side on " "MGW endpoint:%x...\n", rtp_endpoint);
+		 "MDCX/BTS: completing connection for the BTS side on " "MGW endpoint:%x...\n", rtp_endpoint);
 
 	addr.s_addr = osmo_ntohl(lchan->abis_ip.bound_ip);
 	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG,
-		 "BTS expects RTP input on address %s:%u\n", inet_ntoa(addr), lchan->abis_ip.bound_port);
+		 "MDCX/BTS: BTS expects RTP input on address %s:%u\n", inet_ntoa(addr), lchan->abis_ip.bound_port);
 
 	/* Generate MGCP message string */
 	mgcp_msg = (struct mgcp_msg) {
@@ -467,7 +467,7 @@
 	rtp_endpoint = mgcp_ctx->rtp_endpoint;
 
 	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG,
-		 "creating connection for the NET side on " "MGW endpoint:%x...\n", rtp_endpoint);
+		 "CRCX/NET: creating connection for the NET side on " "MGW endpoint:%x...\n", rtp_endpoint);
 
 	/* Currently we only have support for IPv4 in our MGCP software, the
 	 * AoIP part is ready to support IPv6 in theory, because the IE
@@ -477,7 +477,7 @@
 	 * transport identifiers */
 	if (conn->aoip_rtp_addr_remote.ss_family != AF_INET) {
 		LOGPFSML(mgcp_ctx->fsm, LOGL_ERROR,
-			 "endpoint:%x MSC uses unsupported address format in AoIP transport identifier -- aborting...\n",
+			 "CRCX/NET: endpoint:%x MSC uses unsupported address format in AoIP transport identifier -- aborting...\n",
 			 rtp_endpoint);
 		handle_error(mgcp_ctx, MGCP_ERR_UNSUPP_ADDR_FMT);
 		return;
@@ -486,7 +486,7 @@
 	sin = (struct sockaddr_in *)&conn->aoip_rtp_addr_remote;
 	addr = inet_ntoa(sin->sin_addr);
 	port = osmo_ntohs(sin->sin_port);
-	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG, "MSC expects RTP input on address %s:%u\n", addr, port);
+	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG, "CRCX/NET: MSC expects RTP input on address %s:%u\n", addr, port);
 
 	/* Generate MGCP message string */
 	mgcp_msg = (struct mgcp_msg) {

-- 
To view, visit https://gerrit.osmocom.org/4981
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea5ea9e54f4b5c998b1d5fe18a98a94abd7b728b
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list